add idle timeout #118
add idle timeout #118
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #118 +/- ##
==========================================
- Coverage 42.94% 41.94% -1.00%
==========================================
Files 7 7
Lines 482 503 +21
==========================================
+ Hits 207 211 +4
- Misses 275 292 +17 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
| # Container has already stopped, return its status code immediately | ||
| return status | ||
|
|
||
| last_activity = self.user.last_activity |
There was a problem hiding this comment.
So this must be running in the central hub server since it's polling against possibly stopped containers. Is there a CustomDockerSpawner instance per user?
There was a problem hiding this comment.
yea. each user will have a spawner instance.
| self.log.info(f"Last activity for {self.container_name}: {last_activity}") | ||
|
|
||
| if last_activity: | ||
| idle_time = datetime.utcnow() - last_activity |
There was a problem hiding this comment.
utcnow() isn't recommended: https://docs.python.org/3/library/datetime.html#datetime.datetime.utcnow
There was a problem hiding this comment.
Are you sure timezone info isn't necessary?
There was a problem hiding this comment.
yea, both utcnow() and now() are working as expected locally. last_activity = self.user.last_activity doesn't have timezone info either.
Co-authored-by: MrCreosote <[email protected]>
No description provided.